-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to magnolia1 #4422
Migrate to magnolia1 #4422
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4422 +/- ##
==========================================
- Coverage 60.50% 60.48% -0.03%
==========================================
Files 275 275
Lines 9882 9882
Branches 444 438 -6
==========================================
- Hits 5979 5977 -2
- Misses 3903 3905 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock a merge, but see comments
scio-macros/src/main/scala/com/spotify/scio/MagnoliaMacros.scala
Outdated
Show resolved
Hide resolved
scio-macros/src/main/scala/com/spotify/scio/MagnoliaMacros.scala
Outdated
Show resolved
Hide resolved
|
||
type Typeclass[T] = Coder[T] | ||
|
||
def combine[T](ctx: CaseClass[Coder, T]): Coder[T] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the logic on this rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magnolia1
changed its API:
combine
->join
dispatch
->split
The magnolia macro expects those functions to be defined. This code shouldn't be used directly by users anyway
* Migrate to magnolia1 * Update doc links * Remove magnolia1 annotations * Disable formatting block * Improve macro transformation to remove annotations * Prefix type param matchers with tp * Update to released version of magnolify
* Migrate to magnolia1 * Update doc links * Remove magnolia1 annotations * Disable formatting block * Improve macro transformation to remove annotations * Prefix type param matchers with tp * Update to released version of magnolify
This reverts commit 84cff3f.
Fix #4420